NotTheFBI has an issue in the WEATPAC Battleset when playing a scenario. In this case he was playing the Philippines Scenario.

Attached is a copy of the GE log file and the last 2 saved game files.

The GE just crashes without warning.

He is using DonT's Tool Box version 2.9.6.

Attached is the last 2 Saved Game files and the GE Log.

This issue has happened in multiple Scenarios in the WESTPAC Battleset.

 

 

 

NOtTheFBI Crash.zip

I verified that the game freezes at the 16.01.20 game time. (used the last saved game)

Using my AIWindow tool I found a formation patrol event for SG ACS that is corrupt with an out of range value for 'Rings'- see screen shot

by deleting the patrol before the 1.20 time the game will continue. I reproduced the problem by setting up a patrol and 'clicking' near the very edge of the rings to obtain a patrol that is yellowed as a complete 'pie' sector including the centre 'main body' (which should never occur).

I think this is an old issue that I thought had been corrected.

Don

Here is the topic for the old issue/fix

 

Confirmed here in 2024.002.  Thanks for the older issue reference, that helped me skip right to the function in play, MoveAndSetPosition in formedit.c.  It is not a regression from the previous fix, rather a new case with the same end result.  I don't have a fix yet but have a strategy to further debug via a bunch of logging statements.  Debugging isn't super straightforward since if I set breakpoints that is going to result in more windows messages which will prevent the code from acting naturally so it is a case here of log, recreate issue, review logs, tweak code, repeat...

formedit.c FramePatrolRegion tries to figure out what ring is selected and in this crash case it identifies a ring one beyond what the UI shows which leads to the experienced nastiness.  No fix yet.

 

I have a fix that I'm so far testing successfully.  Have I mentioned how much I hate the ancient user interface code?!?  

I'm finally fixing a forever old piece of formation-keeping code that has logic that would occasionally infinitely loop.  It is the code that when a formation patrol is assigned to multiple rings and/or sectors must decide which individual formation spot to go to at that time so not a common use-case but happened to hit when I was testing the crash fix and I finally am conquering.

10 hours ago, TonyE said:

I have a fix that I'm so far testing successfully.  Have I mentioned how much I hate the ancient user interface code?!?  

I'm finally fixing a forever old piece of formation-keeping code that has logic that would occasionally infinitely loop.  It is the code that when a formation patrol is assigned to multiple rings and/or sectors must decide which individual formation spot to go to at that time so not a common use-case but happened to hit when I was testing the crash fix and I finally am conquering.

Hmm, I wonder if it relates to the occasional (still) formation aircraft run dry and ditch. I had one last night I think and Eric recently commented on finding some 'lost' patrol ac wondering off looking for chinese takeaway.

Fix coded for 2024.003

2024.003, confirm fixed for me. Thanks Tony